Skip to content

feat(data-collection): Port Rails controller and ActiveStorage#3033

Open
sl0thentr0py wants to merge 1 commit into
neel/data-collection/integrationsfrom
neel/data-collection/rails
Open

feat(data-collection): Port Rails controller and ActiveStorage#3033
sl0thentr0py wants to merge 1 commit into
neel/data-collection/integrationsfrom
neel/data-collection/rails

Conversation

@sl0thentr0py

@sl0thentr0py sl0thentr0py commented Jul 23, 2026

Copy link
Copy Markdown
Member
  • Rails controller span data query inclusion is modified to comply with URL collection spec.
  • Rails filter_parameters are backfilled into url_query_params
    • Allow regexes in terms as a result to enable this

Issues

@linear-code

linear-code Bot commented Jul 23, 2026

Copy link
Copy Markdown

RUBY-193

Comment thread sentry-rails/lib/sentry/rails/controller_transaction.rb
Comment thread sentry-rails/lib/sentry/rails/railtie.rb Outdated
Comment thread sentry-rails/lib/sentry/rails/railtie.rb Outdated
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/rails branch from 299d82e to b48a5b4 Compare July 23, 2026 13:04
Comment thread sentry-rails/lib/sentry/rails/controller_transaction.rb Outdated
Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/rails branch from b48a5b4 to d0e505c Compare July 23, 2026 13:09
Comment thread sentry-ruby/lib/sentry/utils/http_tracing.rb Outdated
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/rails branch 2 times, most recently from f8de4dc to 033e90e Compare July 23, 2026 14:08
Comment thread sentry-rails/lib/sentry/rails/controller_transaction.rb

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 033e90e. Configure here.

Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb
* Rails controller span data query inclusion is modified to comply with URL collection spec.
* Rails `filter_parameters` are backfilled into `url_query_params`
  * Allow regexes in `terms` as a result to enable this
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/rails branch from 033e90e to bed5b91 Compare July 23, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(pii): Wire Rails request & params (controller, active_storage)

1 participant